]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t0000: cover GIT_SKIP_TESTS blindspots
authorDenton Liu <liu.denton@gmail.com>
Tue, 8 Oct 2019 09:22:47 +0000 (02:22 -0700)
committerJunio C Hamano <gitster@pobox.com>
Wed, 9 Oct 2019 01:47:08 +0000 (10:47 +0900)
Currently, the tests for GIT_SKIP_TESTS do not cover the situation where
we skip an entire test suite. The tests also do not cover the situation
where we have GIT_SKIP_TESTS defined but the test suite does not match.

Add two test cases so we cover this blindspot.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t0000-basic.sh

index 9ca0818cbe4c1fb7f7d4c4558f00c5dabc0ae778..d4923c349e7d08b348dee2bd2629a9b6d670598c 100755 (executable)
@@ -391,6 +391,44 @@ test_expect_success 'GIT_SKIP_TESTS sh pattern' "
        )
 "
 
+test_expect_success 'GIT_SKIP_TESTS entire suite' "
+       (
+               GIT_SKIP_TESTS='git' && export GIT_SKIP_TESTS &&
+               run_sub_test_lib_test git-skip-tests-entire-suite \
+                       'GIT_SKIP_TESTS entire suite' <<-\\EOF &&
+               for i in 1 2 3
+               do
+                       test_expect_success \"passing test #\$i\" 'true'
+               done
+               test_done
+               EOF
+               check_sub_test_lib_test git-skip-tests-entire-suite <<-\\EOF
+               > 1..0 # SKIP skip all tests in git
+               EOF
+       )
+"
+
+test_expect_success 'GIT_SKIP_TESTS does not skip unmatched suite' "
+       (
+               GIT_SKIP_TESTS='notgit' && export GIT_SKIP_TESTS &&
+               run_sub_test_lib_test git-skip-tests-unmatched-suite \
+                       'GIT_SKIP_TESTS does not skip unmatched suite' <<-\\EOF &&
+               for i in 1 2 3
+               do
+                       test_expect_success \"passing test #\$i\" 'true'
+               done
+               test_done
+               EOF
+               check_sub_test_lib_test git-skip-tests-unmatched-suite <<-\\EOF
+               > ok 1 - passing test #1
+               > ok 2 - passing test #2
+               > ok 3 - passing test #3
+               > # passed all 3 test(s)
+               > 1..3
+               EOF
+       )
+"
+
 test_expect_success '--run basic' "
        run_sub_test_lib_test run-basic \
                '--run basic' --run='1 3 5' <<-\\EOF &&