]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t9104: fix test for following larger parents
authorMichael J Gruber <git@drmicha.warpmail.net>
Fri, 20 Mar 2015 14:32:56 +0000 (15:32 +0100)
committerJunio C Hamano <gitster@pobox.com>
Fri, 20 Mar 2015 19:33:14 +0000 (12:33 -0700)
This test is special for several reasons:
It ends with a "true" statement, which should be a no-op.
It is not because the &&-chain is broken right before it.

Also, looking at what the test intended to test according to
7f578c5 (git-svn: --follow-parent now works on sub-directories of larger
branches, 2007-01-24)
it is not clear how it would achieve that with the given steps.

Amend the test to include the second svn id to be tested for, and
change the tested refs to the ones which are to be expected, and which
make the test pass.

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t9104-git-svn-follow-parent.sh

index 13b179e721ef12993ce2bc8f0f59d9f49940447c..83f17e13e805300f03016e8fc66c717db2657f3c 100755 (executable)
@@ -72,16 +72,18 @@ test_expect_success 'follow larger parent' '
         svn import -m "import a larger parent" import "$svnrepo"/larger-parent &&
         svn cp -m "hi" "$svnrepo"/larger-parent "$svnrepo"/another-larger &&
         git svn init --minimize-url -i larger \
-          "$svnrepo"/another-larger/trunk/thunk/bump/thud &&
+         "$svnrepo"/larger-parent/trunk/thunk/bump/thud &&
         git svn fetch -i larger &&
+       git svn init --minimize-url -i larger-parent \
+         "$svnrepo"/another-larger/trunk/thunk/bump/thud &&
+       git svn fetch -i larger-parent &&
         git rev-parse --verify refs/remotes/larger &&
         git rev-parse --verify \
-           refs/remotes/larger-parent/trunk/thunk/bump/thud &&
+          refs/remotes/larger-parent &&
         test "`git merge-base \
-                 refs/remotes/larger-parent/trunk/thunk/bump/thud \
+                refs/remotes/larger-parent \
                  refs/remotes/larger`" = \
              "`git rev-parse refs/remotes/larger`"
-        true
         '
 
 test_expect_success 'follow higher-level parent' '