ref-filter: die on parse_commit errors

The tag-contains algorithm quietly returns "does not
contain" when parse_commit() fails. But a parse failure is
an indication that the repository is corrupt. We should die
loudly rather than producing a bogus result.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/ref-filter.c b/ref-filter.c
index 631978a4f9f41146d4a5446feb5005c4e415dc4d..5cb49b7c242dcfbe9eb8dc4c8b75057b99eaff07 100644 (file)
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -1523,9 +1523,7 @@ static enum contains_result contains_test(struct commit *candidate,
                return CONTAINS_YES;
        }
 
-       if (parse_commit(candidate) < 0)
-               return CONTAINS_NO;
-
+       parse_commit_or_die(candidate);
        return CONTAINS_UNKNOWN;
 }