t3401: add another directory rename testcase for rebase and am

Similar to commit 16346883ab ("t3401: add directory rename testcases for
rebase and am", 2018-06-27), add another testcase for directory rename
detection.  This new testcase differs in that it showcases a situation
where no directory rename was performed, but which some backends
incorrectly detect.

As with the other testcase, run this in conjunction with each of the
types of rebases:
  git-rebase--interactive
  git-rebase--am
  git-rebase--merge
and also use the same testcase for
  git am --3way

Reported-by: Nikolay Kasyanov <corrmage@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t3401-rebase-and-am-rename.sh b/t/t3401-rebase-and-am-rename.sh
index 8f832957fc38110b7653ad0a058172ed9fc8bf1f..887bed53962dec12a9c45567ab987fb8c78fe3f9 100755 (executable)
--- a/t/t3401-rebase-and-am-rename.sh
+++ b/t/t3401-rebase-and-am-rename.sh
@@ -5,7 +5,7 @@ test_description='git rebase + directory rename tests'
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-rebase.sh
 
-test_expect_success 'setup testcase' '
+test_expect_success 'setup testcase where directory rename should be detected' '
        test_create_repo dir-rename &&
        (
                cd dir-rename &&
@@ -102,4 +102,112 @@ test_expect_failure 'am: directory rename detected' '
        )
 '
 
+test_expect_success 'setup testcase where directory rename should NOT be detected' '
+       test_create_repo no-dir-rename &&
+       (
+               cd no-dir-rename &&
+
+               mkdir x &&
+               test_seq  1 10 >x/a &&
+               test_seq 11 20 >x/b &&
+               test_seq 21 30 >x/c &&
+               echo original >project_info &&
+               git add x project_info &&
+               git commit -m "Initial" &&
+
+               git branch O &&
+               git branch A &&
+               git branch B &&
+
+               git checkout A &&
+               echo v2 >project_info &&
+               git add project_info &&
+               git commit -m "Modify project_info" &&
+
+               git checkout B &&
+               mkdir y &&
+               git mv x/c y/c &&
+               echo v1 >project_info &&
+               git add project_info &&
+               git commit -m "Rename x/c to y/c, modify project_info"
+       )
+'
+
+test_expect_success 'rebase --interactive: NO directory rename' '
+       test_when_finished "git -C no-dir-rename rebase --abort" &&
+       (
+               cd no-dir-rename &&
+
+               git checkout B^0 &&
+
+               set_fake_editor &&
+               test_must_fail env FAKE_LINES="1" git rebase --interactive A &&
+
+               git ls-files -s >out &&
+               test_line_count = 6 out &&
+
+               test_path_is_file x/a &&
+               test_path_is_file x/b &&
+               test_path_is_missing x/c
+       )
+'
+
+test_expect_failure 'rebase (am): NO directory rename' '
+       test_when_finished "git -C no-dir-rename rebase --abort" &&
+       (
+               cd no-dir-rename &&
+
+               git checkout B^0 &&
+
+               set_fake_editor &&
+               test_must_fail git rebase A &&
+
+               git ls-files -s >out &&
+               test_line_count = 6 out &&
+
+               test_path_is_file x/a &&
+               test_path_is_file x/b &&
+               test_path_is_missing x/c
+       )
+'
+
+test_expect_success 'rebase --merge: NO directory rename' '
+       test_when_finished "git -C no-dir-rename rebase --abort" &&
+       (
+               cd no-dir-rename &&
+
+               git checkout B^0 &&
+
+               set_fake_editor &&
+               test_must_fail git rebase --merge A &&
+
+               git ls-files -s >out &&
+               test_line_count = 6 out &&
+
+               test_path_is_file x/a &&
+               test_path_is_file x/b &&
+               test_path_is_missing x/c
+       )
+'
+
+test_expect_failure 'am: NO directory rename' '
+       test_when_finished "git -C no-dir-rename am --abort" &&
+       (
+               cd no-dir-rename &&
+
+               git checkout A^0 &&
+
+               git format-patch -1 B &&
+
+               test_must_fail git am --3way 0001*.patch &&
+
+               git ls-files -s >out &&
+               test_line_count = 6 out &&
+
+               test_path_is_file x/a &&
+               test_path_is_file x/b &&
+               test_path_is_missing x/c
+       )
+'
+
 test_done