]> git.ipfire.org Git - thirdparty/git.git/commitdiff
contrib/coverage-diff: avoid redundant pipelines
authorBeat Bolli <bb@drbeat.li>
Fri, 15 Mar 2024 19:46:18 +0000 (20:46 +0100)
committerJunio C Hamano <gitster@pobox.com>
Sat, 16 Mar 2024 18:08:57 +0000 (11:08 -0700)
Merge multiple sed and "grep | awk" invocations, finally use "sort -u"
instead of "sort | uniq".

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
Acked-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/coverage-diff.sh

index 4ec419f90048babf0b18a0f8ca0fce82fc2b3f30..6ce9603568ef7d4b41d7eed9247e8512a2f45a74 100755 (executable)
@@ -74,8 +74,7 @@ do
        sort >uncovered_lines.txt
 
        comm -12 uncovered_lines.txt new_lines.txt |
-       sed -e 's/$/\)/' |
-       sed -e 's/^/ /' >uncovered_new_lines.txt
+       sed -e 's/$/\)/' -e 's/^/ /' >uncovered_new_lines.txt
 
        grep -q '[^[:space:]]' <uncovered_new_lines.txt &&
        echo $file >>coverage-data.txt &&
@@ -91,11 +90,7 @@ cat coverage-data.txt
 
 echo "Commits introducing uncovered code:"
 
-commit_list=$(cat coverage-data.txt |
-       grep -E '^[0-9a-f]{7,} ' |
-       awk '{print $1;}' |
-       sort |
-       uniq)
+commit_list=$(awk '/^[0-9a-f]{7,}/ { print $1 }' coverage-data.txt | sort -u)
 
 (
        for commit in $commit_list