]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
Fix build-and-build-again bug in sunrpc tests.
authorZack Weinberg <zackw@panix.com>
Mon, 14 Nov 2016 19:25:11 +0000 (14:25 -0500)
committerZack Weinberg <zackw@panix.com>
Mon, 14 Nov 2016 19:25:11 +0000 (14:25 -0500)
rpcgen will error out if the file it's asked to create already exists.
Several other rules in sunrpc/Makefile take care to delete rpcgen-
generated files before creating them, but rpcgen-tests doesn't, which
can lead to spurious test failures in an incremental rebuild.

* sunrpc/Makefile (rpcgen-tests): Delete the .out file before
creating or re-creating it.

sunrpc/Makefile

index 99e5c3ccf8e6a0d069548234cda5dcec93f99866..9e805fbb003d43eb7841c8d6af019b3bf6461efa 100644 (file)
@@ -233,6 +233,7 @@ $(objpfx)thrsvc: $(common-objpfx)linkobj/libc.so $(shared-thread-library)
 
 ifeq ($(run-built-tests),yes)
 $(rpcgen-tests): $(objpfx)%.out: %.x $(objpfx)rpcgen
+       -rm -f $@
        $(built-program-cmd) -c $< -o $@; \
        $(evaluate-test)
 endif