]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
stdio: Remove the usage of $(fno-unit-at-a-time) for errlist.c
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Wed, 6 Apr 2022 15:09:42 +0000 (12:09 -0300)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Fri, 13 May 2022 13:54:41 +0000 (10:54 -0300)
The errlist.c is built with -fno-toplevel-reorder to avoid compiler to
reorder the compat assembly directives due an assembler issue [1]
(fixed on 2.39).

This patch removes the compiler flags by split the compat symbol
generation in two phases.  First the _sys_errlist_internal internal
without any compat symbol directive is preprocessed to generate an
assembly source code.  This generate assembly is then used as input
on a platform agnostic errlist-data.S which then creates the compat
definitions.  This prevents compiler to move any compat directive
prior the _sys_errlist_internal definition itself.

Checked on a make check run-built-tests=no on all affected ABIs.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=29012

16 files changed:
Makeconfig
include/stdio.h
stdio-common/Makefile
stdio-common/err_map.h [new file with mode: 0644]
stdio-common/errlist-compat-data.h [new file with mode: 0644]
stdio-common/errlist-compat.c [deleted file]
stdio-common/errlist-data-gen.c [new file with mode: 0644]
stdio-common/errlist-data.S [new file with mode: 0644]
stdio-common/errlist.c
sysdeps/mach/hurd/err_map.h [moved from sysdeps/mach/hurd/errlist.c with 83% similarity]
sysdeps/unix/sysv/linux/alpha/errlist-compat-data.h [moved from sysdeps/unix/sysv/linux/alpha/errlist-compat.c with 100% similarity]
sysdeps/unix/sysv/linux/errlist-compat-data.h [moved from sysdeps/unix/sysv/linux/errlist-compat.c with 100% similarity]
sysdeps/unix/sysv/linux/errlist-compat.h
sysdeps/unix/sysv/linux/hppa/errlist-compat-data.h [moved from sysdeps/unix/sysv/linux/hppa/errlist-compat.c with 100% similarity]
sysdeps/unix/sysv/linux/mips/errlist-compat-data.h [moved from sysdeps/unix/sysv/linux/mips/errlist-compat.c with 100% similarity]
sysdeps/unix/sysv/linux/sparc/errlist-compat-data.h [moved from sysdeps/unix/sysv/linux/sparc/errlist-compat.c with 100% similarity]

index 760f14e92fd61a166d6bb66a90ffeb4bbb2b56ef..b5aa07c4f404c3f3ed5afe4de632221b7da67933 100644 (file)
@@ -1030,7 +1030,8 @@ ifeq (yes,$(build-shared))
 # Under --enable-shared, we will build a shared library of PIC objects.
 # The PIC object files are named foo.os.
 object-suffixes += .os
-CPPFLAGS-.os = -DPIC -DSHARED
+pic-cppflags = -DPIC -DSHARED
+CPPFLAGS-.os = $(pic-cppflags)
 CFLAGS-.os = $(filter %frame-pointer,$(+cflags)) $(pic-ccflag)
 libtype.os := lib%_pic.a
 # This can be changed by a sysdep makefile
index 23b7fd288cdaba66b1740efa8e03b08cd8469b9d..a6f7fd43cb664eb55f4987dfa830466bba38aa5b 100644 (file)
@@ -180,6 +180,7 @@ int __vfxprintf (FILE *__fp, const char *__fmt, __gnuc_va_list,
   attribute_hidden;
 
 extern const char *const _sys_errlist_internal[] attribute_hidden;
+extern const size_t _sys_errlist_internal_len attribute_hidden;
 extern const char *__get_errlist (int) attribute_hidden;
 extern const char *__get_errname (int) attribute_hidden;
 
index a1603e82fe50ee689e4f6981a2fdfa374259bca5..08bc998436a9e0b33f6f9e5a166804bf5eec8d3c 100644 (file)
@@ -88,6 +88,7 @@ routines := \
 
 aux := \
   errlist \
+  errlist-data \
   errname \
   fxprintf \
   printf-parsemb \
@@ -211,6 +212,10 @@ tests := \
   xbug \
   # tests
 
+generated += \
+  errlist-data-aux-shared.S \
+  errlist-data-aux.S \
+  # generated
 
 test-srcs = tst-unbputc tst-printf tst-printfsz-islongdouble
 
@@ -246,6 +251,20 @@ tests-special += $(objpfx)tst-errno-manual.out
 
 include ../Rules
 
+# The errlist.c is built in two phases because compiler might reorder the
+# compat_symbol directive prior the object itself and on binutils older
+# than 2.29 it might generate object sizes different than the expected ones.
+$(objpfx)errlist-data-aux-shared.S: errlist-data-gen.c
+       $(make-target-directory)
+       $(compile-command.c) $(pic-cppflags) $(pic-ccflag) $(no-stack-protector) -S
+
+$(objpfx)errlist-data-aux.S: errlist-data-gen.c
+       $(make-target-directory)
+       $(compile-command.c) $(pie-default) $(no-stack-protector) -S
+
+$(objpfx)errlist-data.os: $(objpfx)errlist-data-aux-shared.S
+$(objpfx)errlist-data.o: $(objpfx)errlist-data-aux.S
+
 ifeq ($(run-built-tests),yes)
 LOCALES := \
   de_DE.ISO-8859-1 \
@@ -334,7 +353,6 @@ CFLAGS-isoc99_vfscanf.c += -fexceptions
 CFLAGS-isoc99_vscanf.c += -fexceptions
 CFLAGS-isoc99_fscanf.c += -fexceptions
 CFLAGS-isoc99_scanf.c += -fexceptions
-CFLAGS-errlist.c += $(fno-unit-at-a-time)
 CFLAGS-siglist.c += $(fno-unit-at-a-time)
 
 # scanf14a.c and scanf16a.c test a deprecated extension which is no
diff --git a/stdio-common/err_map.h b/stdio-common/err_map.h
new file mode 100644 (file)
index 0000000..6cc3aa3
--- /dev/null
@@ -0,0 +1,24 @@
+/* Internal errno names mapping definition.
+   Copyright (C) 2022 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#ifndef _ERR_MAP_H
+#define _ERR_MAP_H
+
+#define ERR_MAP(n) (n)
+
+#endif
diff --git a/stdio-common/errlist-compat-data.h b/stdio-common/errlist-compat-data.h
new file mode 100644 (file)
index 0000000..7c89c9a
--- /dev/null
@@ -0,0 +1 @@
+/* Empty  */
diff --git a/stdio-common/errlist-compat.c b/stdio-common/errlist-compat.c
deleted file mode 100644 (file)
index 6e25b02..0000000
+++ /dev/null
@@ -1 +0,0 @@
-/* Empty.  */
diff --git a/stdio-common/errlist-data-gen.c b/stdio-common/errlist-data-gen.c
new file mode 100644 (file)
index 0000000..db4f50e
--- /dev/null
@@ -0,0 +1,34 @@
+/* Internal errno names mapping definition.
+   Copyright (C) 2022 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <array_length.h>
+#include <err_map.h>
+#include <errno.h>
+#include <libintl.h>
+#include <stdio.h>
+
+const char *const _sys_errlist_internal[] =
+  {
+#define _S(n, str)         [ERR_MAP(n)] = str,
+#include <errlist.h>
+#undef _S
+  };
+const size_t _sys_errlist_internal_len = array_length (_sys_errlist_internal);
+
+/* Include to get the definitions for sys_nerr/_sys_nerr.  */
+#include <errlist-compat-data.h>
diff --git a/stdio-common/errlist-data.S b/stdio-common/errlist-data.S
new file mode 100644 (file)
index 0000000..870b3f4
--- /dev/null
@@ -0,0 +1,7 @@
+#ifdef SHARED
+# include "errlist-data-aux-shared.S"
+#else
+# include "errlist-data-aux.S"
+#endif
+
+#include <errlist-compat-data.h>
index 1c09a31a7adcaa3e1c7070f0ae9e15abbdfe32e2..4c0a0a218df5ce2bf927cdcef36f6a39e980f90d 100644 (file)
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
-#include <stdio.h>
+#include <array_length.h>
+#include <err_map.h>
 #include <errno.h>
 #include <libintl.h>
-#include <array_length.h>
-
-#ifndef ERR_MAP
-# define ERR_MAP(n) n
-#endif
-
-const char *const _sys_errlist_internal[] =
-  {
-#define _S(n, str)         [ERR_MAP(n)] = str,
-#include <errlist.h>
-#undef _S
-  };
+#include <stdio.h>
 
 const char *
 __get_errlist (int errnum)
 {
   int mapped = ERR_MAP (errnum);
-  if (mapped >= 0 && mapped < array_length (_sys_errlist_internal))
+  if (mapped >= 0 && mapped < _sys_errlist_internal_len)
     return _sys_errlist_internal[mapped];
   return NULL;
 }
-
-#include <errlist-compat.c>
similarity index 83%
rename from sysdeps/mach/hurd/errlist.c
rename to sysdeps/mach/hurd/err_map.h
index 2d782ffc67e741cf67023d870e4c5ab8fb5c284b..22d21ca9f1eda0e8e5794591fa2db7f8ca8802bc 100644 (file)
@@ -1,4 +1,5 @@
-/* Copyright (C) 1998-2022 Free Software Foundation, Inc.
+/* Internal errno names mapping definition.  Hurd version.
+   Copyright (C) 2022 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
+#ifndef _ERR_MAP_H
+#define _ERR_MAP_H
+
 #include <mach/error.h>
 
 #define ERR_MAP(value) err_get_code (value)
-#include <stdio-common/errlist.c>
+
+#endif
index a09b38f24317923ddcea887b5dd82565f27c55de..33008863f86d0221f14add5f6bda932c5b6d5b5d 100644 (file)
@@ -20,6 +20,7 @@
 #define _ERRLIST_COMPAT_H
 
 #include <shlib-compat.h>
+#include <limits.h>
 
 /* Define new compat symbols for symbols  _sys_errlist, sys_errlist,
    _sys_nerr, and sys_nerr for version VERSION with NUMBERERR times number of
    Both _sys_errlist and sys_errlist alias to _sys_errlist_internal symbol
    (defined on errlist.c) while _sys_nerr and sys_nerr created new variable
    with the expected size.  */
-#define DEFINE_COMPAT_ERRLIST(NUMBERERR, VERSION)                           \
-  const int __##VERSION##_sys_nerr = NUMBERERR;                                     \
-  strong_alias (__##VERSION##_sys_nerr, __##VERSION##__sys_nerr);           \
-  declare_symbol_alias (__ ## VERSION ## _sys_errlist, _sys_errlist_internal,\
-                       object, NUMBERERR * (ULONG_WIDTH / UCHAR_WIDTH));    \
-  declare_symbol_alias (__ ## VERSION ## __sys_errlist,                             \
-                       _sys_errlist_internal, object,                       \
-                       NUMBERERR * (ULONG_WIDTH / UCHAR_WIDTH));            \
-  compat_symbol (libc, __## VERSION ## _sys_nerr, sys_nerr, VERSION);       \
-  compat_symbol (libc, __## VERSION ## __sys_nerr, _sys_nerr, VERSION);      \
-  compat_symbol (libc, __## VERSION ## _sys_errlist, sys_errlist, VERSION);  \
-  compat_symbol (libc, __## VERSION ## __sys_errlist, _sys_errlist, VERSION);\
+#ifdef __ASSEMBLER__
+# define DEFINE_COMPAT_ERRLIST(NUMBERERR, VERSION)                         \
+  declare_object_symbol_alias (__ ## VERSION ## _sys_errlist,              \
+                              _sys_errlist_internal,                       \
+                              NUMBERERR * (ULONG_WIDTH / UCHAR_WIDTH))     \
+                              ASM_LINE_SEP                                 \
+  declare_object_symbol_alias (__ ## VERSION ## __sys_errlist,             \
+                              _sys_errlist_internal,                       \
+                              NUMBERERR * (ULONG_WIDTH / UCHAR_WIDTH))     \
+                              ASM_LINE_SEP                                 \
+  compat_symbol (libc, __## VERSION ## _sys_errlist, sys_errlist, VERSION)  \
+                ASM_LINE_SEP                                               \
+  compat_symbol (libc, __## VERSION ## __sys_errlist, _sys_errlist, VERSION)
+#else
+# define DEFINE_COMPAT_ERRLIST(NUMBERERR, VERSION)                         \
+  const int __##VERSION##_sys_nerr = NUMBERERR;                                    \
+  strong_alias (__##VERSION##_sys_nerr, __##VERSION##__sys_nerr);          \
+  compat_symbol (libc, __## VERSION ## _sys_nerr, sys_nerr, VERSION);      \
+  compat_symbol (libc, __## VERSION ## __sys_nerr, _sys_nerr, VERSION);
+#endif
 
 #endif