Makeconfig: Do not sort and deduplicate +cflags [BZ # 17248]

The original intent behind this is unclear.  It interferes with flags
that has to be ordered in a particular way.

diff --git a/ChangeLog b/ChangeLog
index 408d7356adee2e175ec8ec43a7ec3534f2111027..d8341077546ee93c3bea6e96388112acc1c54a7a 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-21  Florian Weimer  <fweimer@redhat.com>
+
+       [BZ #17248]
+       * Makeconfig (+cflags): Do not sort (and deduplicate).
+
 2018-08-21  Florian Weimer  <fweimer@redhat.com>
 
        * debug/readlink_chk.c (__readlink_chk): Always call __readlink.

diff --git a/Makeconfig b/Makeconfig
index 92e76d6200bbcd5bb5f654ca993f227ece3d8215..a9e50e5b60ac3c4d1ca11b6a338ff10bf1c462b6 100644 (file)
--- a/Makeconfig
+++ b/Makeconfig
@@ -902,9 +902,6 @@ endif       # $(+cflags) == ""
           $(+stack-protector)
 +gcc-nowarn := -w
 
-# Don't duplicate options if we inherited variables from the parent.
-+cflags        := $(sort $(+cflags))
-
 # Each sysdeps directory can contain header files that both will be
 # used to compile and will be installed.  Each can also contain an
 # include/ subdirectory, whose header files will be used to compile