]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
Do not clobber sp in _hurd_stack_setup.
authorJoseph Myers <joseph@codesourcery.com>
Thu, 13 Dec 2018 22:36:33 +0000 (22:36 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Thu, 13 Dec 2018 22:36:33 +0000 (22:36 +0000)
GCC mainline now gives errors for an asm that clobbers the stack
pointer.  According to
<https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00932.html> GCC
previously ignored such a clobber; thus, this patch removes it from
_hurd_stack_setup.

Tested with build-many-glibcs.py for i686-gnu.

* sysdeps/mach/hurd/i386/init-first.c (_hurd_stack_setup): Do not
clobber sp.

ChangeLog
sysdeps/mach/hurd/i386/init-first.c

index e457d581e90131bb5abc9a847ed1f30d32e9ed0e..e419448fe6b79906da0272983bde2d2d20a79a12 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-12-13  Joseph Myers  <joseph@codesourcery.com>
+
+       * sysdeps/mach/hurd/i386/init-first.c (_hurd_stack_setup): Do not
+       clobber sp.
+
 2018-12-13  fanjinke  <fanjinke@hygon.cn>
 
        * sysdeps/x86/cpu-features.c (init_cpu_features): Check for
index f8ad2ceb8e324f92ec7768aaa7615dab5d1824a9..e3d579726665cf1fc1cb74c39fe8723faaa753da 100644 (file)
@@ -361,7 +361,7 @@ _hurd_stack_setup (void)
       *--data = caller;
       asm volatile ("movl %0, %%esp\n" /* Switch to new outermost stack.  */
                    "movl $0, %%ebp\n" /* Clear outermost frame pointer.  */
-                   "jmp *%1" : : "r" (data), "r" (&doinit1) : "sp");
+                   "jmp *%1" : : "r" (data), "r" (&doinit1));
       /* NOTREACHED */
     }