]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
Rewrite abi-note.S in C.
authorSzabolcs Nagy <szabolcs.nagy@arm.com>
Wed, 1 Apr 2020 15:02:03 +0000 (16:02 +0100)
committerSzabolcs Nagy <szabolcs.nagy@arm.com>
Wed, 8 Jul 2020 14:02:37 +0000 (15:02 +0100)
Using C code allows the compiler to add target specific object file
markings based on CFLAGS.

The arm specific abi-note.S is removed and similar object file fix
up will be avoided on AArch64 with standard branch protection.

csu/abi-note.c [moved from csu/abi-note.S with 89% similarity]
sysdeps/arm/abi-note.S [deleted file]

similarity index 89%
rename from csu/abi-note.S
rename to csu/abi-note.c
index 2b4b5f88247657fcf6f0cf4fc85240bb75023f7e..8febf4cac089189b00692a1bf05503f5f4499ac9 100644 (file)
@@ -53,6 +53,8 @@ offset        length  contents
    identify the earliest release of that OS that supports this ABI.
    See abi-tags (top level) for details. */
 
+#include <link.h>
+#include <stdint.h>
 #include <config.h>
 #include <abi-tag.h>           /* OS-specific ABI tag value */
 
@@ -60,13 +62,16 @@ offset      length  contents
    name begins with `.note' and creates a PT_NOTE program header entry
    pointing at it. */
 
-       .section ".note.ABI-tag", "a"
-       .p2align 2
-       .long 1f - 0f           /* name length */
-       .long 3f - 2f           /* data length */
-       .long  1                /* note type */
-0:     .asciz "GNU"            /* vendor name */
-1:     .p2align 2
-2:     .long __ABI_TAG_OS      /* note data: the ABI tag */
-       .long __ABI_TAG_VERSION
-3:     .p2align 2              /* pad out section */
+__attribute__ ((used, aligned (4), section (".note.ABI-tag")))
+static const struct
+{
+  ElfW(Nhdr) nhdr;
+  char name[4];
+  int32_t desc[4];
+} __abi_tag = {
+  { .n_namesz = sizeof __abi_tag.name,
+    .n_descsz = sizeof __abi_tag.desc,
+    .n_type = 1 },
+  "GNU",
+  { __ABI_TAG_OS, __ABI_TAG_VERSION }
+};
diff --git a/sysdeps/arm/abi-note.S b/sysdeps/arm/abi-note.S
deleted file mode 100644 (file)
index 07bd4c4..0000000
+++ /dev/null
@@ -1,8 +0,0 @@
-/* Tag_ABI_align8_preserved: This code preserves 8-byte
-   alignment in any callee.  */
-       .eabi_attribute 25, 1
-/* Tag_ABI_align8_needed: This code may require 8-byte alignment from
-   the caller.  */
-       .eabi_attribute 24, 1
-
-#include <csu/abi-note.S>