]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
WPS: Do not set auth_alg=OPEN for PSK+SAE case
authorJouni Malinen <jouni@codeaurora.org>
Tue, 10 Mar 2020 18:48:15 +0000 (20:48 +0200)
committerJouni Malinen <j@w1.fi>
Tue, 10 Mar 2020 18:48:15 +0000 (20:48 +0200)
When wps_cred_add_sae=1 is used, WPS_AUTH_WPA2PSK credential gets
converted to enabling both PSK and SAE AKMs. However, this case was
still hardcoded auth_alg=OPEN which is not really correct for SAE. While
the SME-in-wpa_supplicant case can handle that, the SME-in-driver case
might not. Remove the unnecessary auth_alg=OPEN configuration to get the
normal PSK+SAE configuration enabled for the network profile.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
wpa_supplicant/wps_supplicant.c

index 063b4e69f9f3d7556bc5be7c1eef161d11ca61f0..a10c34cf0eb9fe6316e54f9c3b4da7fe22b40538 100644 (file)
@@ -532,6 +532,7 @@ static int wpa_supplicant_wps_cred(void *ctx,
                ssid->key_mgmt = WPA_KEY_MGMT_PSK;
                if (wpa_s->conf->wps_cred_add_sae &&
                    cred->key_len != 2 * PMK_LEN) {
+                       ssid->auth_alg = 0;
                        ssid->key_mgmt |= WPA_KEY_MGMT_SAE;
                        ssid->ieee80211w = MGMT_FRAME_PROTECTION_OPTIONAL;
                }