ctrl: Fix fd leak in ctrl_list()

if ctrl_list is called with get operation and wrong number
of parameters, it would forget to close the local netlink
handle.

Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

diff --git a/genl/ctrl.c b/genl/ctrl.c
index aff922a436bf5907c31b471f749d310b3e68cc8c..bae73a54bc37e595bff06f914b9dbfad9d4a83b0 100644 (file)
--- a/genl/ctrl.c
+++ b/genl/ctrl.c
@@ -267,7 +267,7 @@ static int ctrl_list(int cmd, int argc, char **argv)
 
                if (argc != 2) {
                        fprintf(stderr, "Wrong number of params\n");
-                       return -1;
+                       goto ctrl_done;
                }
 
                if (matches(*argv, "name") == 0) {