]> git.ipfire.org Git - thirdparty/iw.git/commitdiff
add comment about monitor flags bug
authorJohannes Berg <johannes@sipsolutions.net>
Wed, 15 Oct 2008 09:55:42 +0000 (11:55 +0200)
committerJohannes Berg <johannes@sipsolutions.net>
Wed, 15 Oct 2008 09:55:42 +0000 (11:55 +0200)
interface.c

index d83a0231d9c26ba9c4db52093cbae48b3a61ac22..e8f3ea1bb142e517cb203370f55450bb494e0f56 100644 (file)
@@ -39,6 +39,13 @@ static int parse_mntr_flags(int *_argc, char ***_argv,
                     flag < NL80211_MNTR_FLAG_MAX; flag++) {
                        if (strcmp(*argv, mntr_flags[flag]) == 0) {
                                ok = 1;
+                               /*
+                                * This shouldn't be adding "flag" if that is
+                                * zero, but due to a problem in the kernel's
+                                * nl80211 code (using NLA_NESTED policy) it
+                                * will reject an empty nested attribute but
+                                * not one that contains an invalid attribute
+                                */
                                NLA_PUT_FLAG(flags, flag);
                                break;
                        }