]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
splice: remove permission hook from do_splice_direct()
authorAmir Goldstein <amir73il@gmail.com>
Wed, 22 Nov 2023 12:27:01 +0000 (14:27 +0200)
committerChristian Brauner <brauner@kernel.org>
Fri, 24 Nov 2023 08:22:27 +0000 (09:22 +0100)
commit2a33e2ddc6ebf9b5468091aded8a38f57de9a580
tree115438e435c36d6e345343541c5f4bafe7ef55b7
parentca7ab482401cf0a7497dad05f4918dc64115538b
splice: remove permission hook from do_splice_direct()

All callers of do_splice_direct() have a call to rw_verify_area() for
the entire range that is being copied, e.g. by vfs_copy_file_range() or
do_sendfile() before calling do_splice_direct().

The rw_verify_area() check inside do_splice_direct() is redundant and
is called after sb_start_write(), so it is not "start-write-safe".
Remove this redundant check.

This is needed for fanotify "pre content" events.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Link: https://lore.kernel.org/r/20231122122715.2561213-3-amir73il@gmail.com
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/splice.c