crypto: sun8i-ss - remove unnecessary alignmask for ahashes

The crypto API's support for alignmasks for ahash algorithms is nearly
useless, as its only effect is to cause the API to align the key and
result buffers.  The drivers that happen to be specifying an alignmask
for ahash rarely actually need it.  When they do, it's easily fixable,
especially considering that these buffers cannot be used for DMA.

In preparation for removing alignmask support from ahash, this patch
makes the sun8i-ss driver no longer use it.  This driver didn't actually
rely on it; it only writes to the result buffer in sun8i_ss_hash_run(),
simply using memcpy().  And sun8i_ss_hmac_setkey() does not assume any
alignment for the key buffer.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
index f14c60359d195d2174d23af284ba3f59e7f691e4..0dbc0220146c71dc04591a9d75d220623ed729b0 100644 (file)
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
@@ -322,7 +322,6 @@ static struct sun8i_ss_alg_template ss_algs[] = {
                                .cra_name = "md5",
                                .cra_driver_name = "md5-sun8i-ss",
                                .cra_priority = 300,
-                               .cra_alignmask = 3,
                                .cra_flags = CRYPTO_ALG_TYPE_AHASH |
                                        CRYPTO_ALG_ASYNC |
                                        CRYPTO_ALG_NEED_FALLBACK,
@@ -355,7 +354,6 @@ static struct sun8i_ss_alg_template ss_algs[] = {
                                .cra_name = "sha1",
                                .cra_driver_name = "sha1-sun8i-ss",
                                .cra_priority = 300,
-                               .cra_alignmask = 3,
                                .cra_flags = CRYPTO_ALG_TYPE_AHASH |
                                        CRYPTO_ALG_ASYNC |
                                        CRYPTO_ALG_NEED_FALLBACK,
@@ -388,7 +386,6 @@ static struct sun8i_ss_alg_template ss_algs[] = {
                                .cra_name = "sha224",
                                .cra_driver_name = "sha224-sun8i-ss",
                                .cra_priority = 300,
-                               .cra_alignmask = 3,
                                .cra_flags = CRYPTO_ALG_TYPE_AHASH |
                                        CRYPTO_ALG_ASYNC |
                                        CRYPTO_ALG_NEED_FALLBACK,
@@ -421,7 +418,6 @@ static struct sun8i_ss_alg_template ss_algs[] = {
                                .cra_name = "sha256",
                                .cra_driver_name = "sha256-sun8i-ss",
                                .cra_priority = 300,
-                               .cra_alignmask = 3,
                                .cra_flags = CRYPTO_ALG_TYPE_AHASH |
                                        CRYPTO_ALG_ASYNC |
                                        CRYPTO_ALG_NEED_FALLBACK,
@@ -455,7 +451,6 @@ static struct sun8i_ss_alg_template ss_algs[] = {
                                .cra_name = "hmac(sha1)",
                                .cra_driver_name = "hmac-sha1-sun8i-ss",
                                .cra_priority = 300,
-                               .cra_alignmask = 3,
                                .cra_flags = CRYPTO_ALG_TYPE_AHASH |
                                        CRYPTO_ALG_ASYNC |
                                        CRYPTO_ALG_NEED_FALLBACK,