]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
Revert "ALSA: hda: call runtime_allow() for all hda controllers"
authorHui Wang <hui.wang@canonical.com>
Mon, 3 Aug 2020 06:46:38 +0000 (14:46 +0800)
committerTakashi Iwai <tiwai@suse.de>
Mon, 3 Aug 2020 07:28:41 +0000 (09:28 +0200)
This reverts commit 9a6418487b56 ("ALSA: hda: call runtime_allow()
for all hda controllers").

The reverted patch already introduced some regressions on some
machines:
 - on gemini-lake machines, the error of "azx_get_response timeout"
   happens in the hda driver.
 - on the machines with alc662 codec, the audio jack detection doesn't
   work anymore.

Fixes: 9a6418487b56 ("ALSA: hda: call runtime_allow() for all hda controllers")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=208511
Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Link: https://lore.kernel.org/r/20200803064638.6139-1-hui.wang@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_intel.c

index e699873c82934070d29d554ab3b4850515abb2b1..e34a4d5d047c18e5eeea9968e0f9915ed7476dc1 100644 (file)
@@ -2352,7 +2352,6 @@ static int azx_probe_continue(struct azx *chip)
 
        if (azx_has_pm_runtime(chip)) {
                pm_runtime_use_autosuspend(&pci->dev);
-               pm_runtime_allow(&pci->dev);
                pm_runtime_put_autosuspend(&pci->dev);
        }