]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mmc: sdhci: sdhci-pci-o2micro: Correctly set bus width when tuning
authorRaul E Rangel <rrangel@chromium.org>
Mon, 17 Jun 2019 20:10:12 +0000 (14:10 -0600)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 18 Jun 2019 11:38:06 +0000 (13:38 +0200)
The O2Micro controller only supports tuning at 4-bits. So the host driver
needs to change the bus width while tuning and then set it back when done.

There was a bug in the original implementation in that mmc->ios.bus_width
also wasn't updated. Thus setting the incorrect blocksize in
sdhci_send_tuning which results in a tuning failure.

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Fixes: 0086fc217d5d7 ("mmc: sdhci: Add support for O2 hardware tuning")
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-pci-o2micro.c

index b29bf4e7dcb485e8e035723a490815457503d096..dd21315922c87da795852e75ac24a7de4a9a19cf 100644 (file)
@@ -115,6 +115,7 @@ static int sdhci_o2_execute_tuning(struct mmc_host *mmc, u32 opcode)
         */
        if (mmc->ios.bus_width == MMC_BUS_WIDTH_8) {
                current_bus_width = mmc->ios.bus_width;
+               mmc->ios.bus_width = MMC_BUS_WIDTH_4;
                sdhci_set_bus_width(host, MMC_BUS_WIDTH_4);
        }
 
@@ -126,8 +127,10 @@ static int sdhci_o2_execute_tuning(struct mmc_host *mmc, u32 opcode)
 
        sdhci_end_tuning(host);
 
-       if (current_bus_width == MMC_BUS_WIDTH_8)
+       if (current_bus_width == MMC_BUS_WIDTH_8) {
+               mmc->ios.bus_width = MMC_BUS_WIDTH_8;
                sdhci_set_bus_width(host, current_bus_width);
+       }
 
        host->flags &= ~SDHCI_HS400_TUNING;
        return 0;