]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: ocelot: remove redundant assignment to variable ret
authorColin Ian King <colin.i.king@gmail.com>
Fri, 23 Feb 2024 16:28:50 +0000 (16:28 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 29 Feb 2024 13:38:09 +0000 (14:38 +0100)
The variable ret is being assigned a value that is never read, it
is being re-assigned a value in every case statement in the following
switch statement. The assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/pinctrl/pinctrl-ocelot.c:1404:3: warning: Value stored to 'ret'
is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20240223162850.3914349-1-colin.i.king@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-ocelot.c

index 52aadd6d72a80f74011efe30b309eea19fd55903..be9b8c01016708fa2e7810ad66f898a97705abac 100644 (file)
@@ -1401,7 +1401,6 @@ static int ocelot_hw_set_value(struct ocelot_pinctrl *info,
        if (info->pincfg) {
                const struct ocelot_pincfg_data *opd = info->pincfg_data;
 
-               ret = 0;
                switch (reg) {
                case PINCONF_BIAS:
                        ret = ocelot_pincfg_clrsetbits(info, pin,