]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
crypto: arm64/sha512 - clean up backwards function names
authorEric Biggers <ebiggers@google.com>
Tue, 10 Oct 2023 06:41:27 +0000 (23:41 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 20 Oct 2023 05:39:26 +0000 (13:39 +0800)
In the Linux kernel, a function whose name has two leading underscores
is conventionally called by the same-named function without leading
underscores -- not the other way around.  __sha512_block_data_order()
got this backwards.  Fix this, albeit without changing the name in the
perlasm since that is OpenSSL code.  No change in behavior.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/arm64/crypto/sha512-glue.c

index 2acff1c7df5d7699d22674d23ead6a57e59e6c0e..62f129dea83d89b5767f093d11bcd06d8a3c0f87 100644 (file)
@@ -23,8 +23,8 @@ asmlinkage void sha512_block_data_order(u64 *digest, const void *data,
                                        unsigned int num_blks);
 EXPORT_SYMBOL(sha512_block_data_order);
 
-static void __sha512_block_data_order(struct sha512_state *sst, u8 const *src,
-                                     int blocks)
+static void sha512_arm64_transform(struct sha512_state *sst, u8 const *src,
+                                  int blocks)
 {
        sha512_block_data_order(sst->state, src, blocks);
 }
@@ -32,17 +32,15 @@ static void __sha512_block_data_order(struct sha512_state *sst, u8 const *src,
 static int sha512_update(struct shash_desc *desc, const u8 *data,
                         unsigned int len)
 {
-       return sha512_base_do_update(desc, data, len,
-                                    __sha512_block_data_order);
+       return sha512_base_do_update(desc, data, len, sha512_arm64_transform);
 }
 
 static int sha512_finup(struct shash_desc *desc, const u8 *data,
                        unsigned int len, u8 *out)
 {
        if (len)
-               sha512_base_do_update(desc, data, len,
-                                     __sha512_block_data_order);
-       sha512_base_do_finalize(desc, __sha512_block_data_order);
+               sha512_base_do_update(desc, data, len, sha512_arm64_transform);
+       sha512_base_do_finalize(desc, sha512_arm64_transform);
 
        return sha512_base_finish(desc, out);
 }