]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
perf report: Prevent segfault with --no-parent
authorAndi Kleen <ak@linux.intel.com>
Tue, 30 Jan 2024 18:55:52 +0000 (10:55 -0800)
committerNamhyung Kim <namhyung@kernel.org>
Fri, 2 Feb 2024 06:15:31 +0000 (22:15 -0800)
Prevent a perf report segfault with the (non sensical) --no-parent
option

Signed-off-By: Andi Kleen <ak@linux.intel.com>
Acked-by: Namhyung <namhyung@kernel.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240130185552.150578-1-ak@linux.intel.com
tools/perf/util/sort.c

index 30254eb637099b07427d73944a6bb4e7baffc724..92a1bd695e8aa3f8bab45818942f098caea44756 100644 (file)
@@ -3372,7 +3372,7 @@ int sort_dimension__add(struct perf_hpp_list *list, const char *tok,
                                sort_dimension_add_dynamic_header(sd);
                }
 
-               if (sd->entry == &sort_parent) {
+               if (sd->entry == &sort_parent && parent_pattern) {
                        int ret = regcomp(&parent_regex, parent_pattern, REG_EXTENDED);
                        if (ret) {
                                char err[BUFSIZ];