]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: hda - fix the micmute led status for Lenovo ThinkCentre AIO
authorHui Wang <hui.wang@canonical.com>
Mon, 10 Aug 2020 02:16:59 +0000 (10:16 +0800)
committerTakashi Iwai <tiwai@suse.de>
Mon, 10 Aug 2020 06:44:49 +0000 (08:44 +0200)
After installing the Ubuntu Linux, the micmute led status is not
correct. Users expect that the led is on if the capture is disabled,
but with the current kernel, the led is off with the capture disabled.

We tried the old linux kernel like linux-4.15, there is no this issue.
It looks like we introduced this issue when switching to the led_cdev.

Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Link: https://lore.kernel.org/r/20200810021659.7429-1-hui.wang@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_realtek.c

index daedcc0adc21c81101dd9651fdf49ba63c057620..09d93dd88713b04f7ecba92fe71224f4c2f6602b 100644 (file)
@@ -4414,6 +4414,7 @@ static void alc233_fixup_lenovo_line2_mic_hotkey(struct hda_codec *codec,
 {
        struct alc_spec *spec = codec->spec;
 
+       spec->micmute_led_polarity = 1;
        alc_fixup_hp_gpio_led(codec, action, 0, 0x04);
        if (action == HDA_FIXUP_ACT_PRE_PROBE) {
                spec->init_amp = ALC_INIT_DEFAULT;