]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ipmi: When handling send message responses, don't process the message
authorCorey Minyard <cminyard@mvista.com>
Tue, 19 Apr 2022 17:08:09 +0000 (12:08 -0500)
committerCorey Minyard <cminyard@mvista.com>
Fri, 29 Apr 2022 15:06:37 +0000 (10:06 -0500)
A chunk was dropped when the code handling send messages was rewritten.
Those messages shouldn't be processed normally, they are just an
indication that the message was successfully sent and the timers should
be started for the real response that should be coming later.

Add back in the missing chunk to just discard the message and go on.

Fixes: 059747c245f0 ("ipmi: Add support for IPMB direct messages")
Reported-by: Joe Wiese <jwiese@rackspace.com>
Cc: stable@vger.kernel.org # v5.16+
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Tested-by: Joe Wiese <jwiese@rackspace.com>
drivers/char/ipmi/ipmi_msghandler.c

index c59265146e9c87b0bbd8e222fc557515f4b48d6a..5f7abf456a177bd9146c4adbcd586f5f1d546253 100644 (file)
@@ -4518,6 +4518,8 @@ return_unspecified:
                } else
                        /* The message was sent, start the timer. */
                        intf_start_seq_timer(intf, msg->msgid);
+               requeue = 0;
+               goto out;
        } else if (((msg->rsp[0] >> 2) != ((msg->data[0] >> 2) | 1))
                   || (msg->rsp[1] != msg->data[1])) {
                /*