]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
selftests/bpf: fix stacktrace_build_id with missing kprobe/urandom_read
authorSong Liu <song@kernel.org>
Thu, 26 May 2022 19:16:08 +0000 (12:16 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 27 May 2022 14:57:25 +0000 (07:57 -0700)
Kernel function urandom_read is replaced with urandom_read_iter.
Therefore, kprobe on urandom_read is not working any more:

[root@eth50-1 bpf]# ./test_progs -n 161
test_stacktrace_build_id:PASS:skel_open_and_load 0 nsec
libbpf: kprobe perf_event_open() failed: No such file or directory
libbpf: prog 'oncpu': failed to create kprobe 'urandom_read+0x0' \
        perf event: No such file or directory
libbpf: prog 'oncpu': failed to auto-attach: -2
test_stacktrace_build_id:FAIL:attach_tp err -2
161     stacktrace_build_id:FAIL

Fix this by replacing urandom_read with urandom_read_iter in the test.

Fixes: 1b388e7765f2 ("random: convert to using fops->read_iter()")
Reported-by: Mykola Lysenko <mykolal@fb.com>
Signed-off-by: Song Liu <song@kernel.org>
Acked-by: David Vernet <void@manifault.com>
Link: https://lore.kernel.org/r/20220526191608.2364049-1-song@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/progs/test_stacktrace_build_id.c

index 6c62bfb8bb6faa24de1a68dbb08018c3ff4438f8..0c4426592a26053416a090ba2ec6faa341c62a10 100644 (file)
@@ -39,7 +39,7 @@ struct {
        __type(value, stack_trace_t);
 } stack_amap SEC(".maps");
 
-SEC("kprobe/urandom_read")
+SEC("kprobe/urandom_read_iter")
 int oncpu(struct pt_regs *args)
 {
        __u32 max_len = sizeof(struct bpf_stack_build_id)