]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
x86/timer: Don't inline __const_udelay()
authorAndi Kleen <ak@linux.intel.com>
Sat, 30 Mar 2019 00:47:38 +0000 (17:47 -0700)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 19 Apr 2019 15:49:47 +0000 (17:49 +0200)
LTO will happily inline __const_udelay() everywhere it is used.  Forcing it
noinline saves ~44k text in a LTO build.

13999560        1740864 1499136 17239560        1070e08 vmlinux-with-udelay-inline
13954764        1736768 1499136 17190668        1064f0c vmlinux-wo-udelay-inline

Even without LTO this function should never be inlined.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190330004743.29541-4-andi@firstfloor.org
arch/x86/lib/delay.c

index f5b7f1b3b6d75ce6024f7ab7459586b1f124902d..b7375dc6898f3215966359a2de29a6b8fc9ce592 100644 (file)
@@ -162,7 +162,7 @@ void __delay(unsigned long loops)
 }
 EXPORT_SYMBOL(__delay);
 
-void __const_udelay(unsigned long xloops)
+noinline void __const_udelay(unsigned long xloops)
 {
        unsigned long lpj = this_cpu_read(cpu_info.loops_per_jiffy) ? : loops_per_jiffy;
        int d0;