]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cifs: Fix a debug message
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 5 Jan 2019 12:25:29 +0000 (15:25 +0300)
committerSteve French <stfrench@microsoft.com>
Thu, 10 Jan 2019 20:32:27 +0000 (14:32 -0600)
This debug message was never shown because it was checking for NULL
returns but extract_hostname() returns error pointers.

Fixes: 93d5cb517db3 ("cifs: Add support for failover in cifs_reconnect()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Paulo Alcantara <palcantara@suse.de>
fs/cifs/connect.c

index f66529679ca2c6238c02c8c38b0e202c3b27398c..683310f261718d3d07088342fde4b89a27bac4bc 100644 (file)
@@ -433,9 +433,10 @@ static void reconn_inval_dfs_target(struct TCP_Server_Info *server,
        kfree(server->hostname);
 
        server->hostname = extract_hostname(name);
-       if (!server->hostname) {
-               cifs_dbg(FYI, "%s: failed to extract hostname from target: %d\n",
-                        __func__, -ENOMEM);
+       if (IS_ERR(server->hostname)) {
+               cifs_dbg(FYI,
+                        "%s: failed to extract hostname from target: %ld\n",
+                        __func__, PTR_ERR(server->hostname));
        }
 }