]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: mt76: Remove redundant assignment to variable tidno
authorColin Ian King <colin.i.king@gmail.com>
Wed, 7 Feb 2024 13:11:13 +0000 (13:11 +0000)
committerFelix Fietkau <nbd@nbd.name>
Thu, 22 Feb 2024 08:55:19 +0000 (09:55 +0100)
The variable tidno is being assigned a value that is not being read
and is being re-assigned a new value a few statements later.
The assignment is redundant and can be removed.

Cleans up clang scan warning:
drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored
to 'tidno' during its initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/agg-rx.c

index 10cbd9e560e72670a830903203ccfc2951c2bd8b..07c386c7b4d08967f5dcb69ee9282b042afbce10 100644 (file)
@@ -122,7 +122,7 @@ mt76_rx_aggr_check_ctl(struct sk_buff *skb, struct sk_buff_head *frames)
        struct ieee80211_bar *bar = mt76_skb_get_hdr(skb);
        struct mt76_wcid *wcid = status->wcid;
        struct mt76_rx_tid *tid;
-       u8 tidno = status->qos_ctl & IEEE80211_QOS_CTL_TID_MASK;
+       u8 tidno;
        u16 seqno;
 
        if (!ieee80211_is_ctl(bar->frame_control))