]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/x86: thinkpad_acpi: cleanup for Thinkpad ACPI led
authorPavel Machek <pavel@ucw.cz>
Mon, 29 Apr 2019 15:21:48 +0000 (17:21 +0200)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 8 May 2019 21:33:03 +0000 (00:33 +0300)
Make error returns more consistent... no behaviour change intended.

Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/thinkpad_acpi.c

index 4c23302e32168461b735ab0c77c3c2b41fa0d579..71cfaf26efd13480a125b90586bf35d272dc289e 100644 (file)
@@ -5876,7 +5876,7 @@ static int led_set_status(const unsigned int led,
                        return -EPERM;
                if (!acpi_evalf(led_handle, NULL, NULL, "vdd",
                                (1 << led), led_sled_arg1[ledstatus]))
-                       rc = -EIO;
+                       return -EIO;
                break;
        case TPACPI_LED_OLD:
                /* 600e/x, 770e, 770x, A21e, A2xm/p, T20-22, X20 */
@@ -5900,10 +5900,10 @@ static int led_set_status(const unsigned int led,
                        return -EPERM;
                if (!acpi_evalf(led_handle, NULL, NULL, "vdd",
                                led, led_led_arg1[ledstatus]))
-                       rc = -EIO;
+                       return -EIO;
                break;
        default:
-               rc = -ENXIO;
+               return -ENXIO;
        }
 
        if (!rc)