]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
NFS: Remove a bogus flag setting in pnfs_write_done_resend_to_mds
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Sat, 13 Aug 2022 12:46:35 +0000 (08:46 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Sat, 13 Aug 2022 17:02:14 +0000 (13:02 -0400)
Since pnfs_write_done_resend_to_mds() does not actually call
end_page_writeback() on the pages that are being redirected to the
metadata server, callers of fsync() do not see the I/O as complete until
the writeback to the MDS finishes. We therefore do not need to set
NFS_CONTEXT_RESEND_WRITES, since there is nothing to redrive.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/pnfs.c

index 41a9b6b58fb9fa15c9f162fa8dfa267a1c16e049..2613b7e36eb956374d70315171460a7d35d0ce51 100644 (file)
@@ -2817,7 +2817,6 @@ int pnfs_write_done_resend_to_mds(struct nfs_pgio_header *hdr)
        /* Resend all requests through the MDS */
        nfs_pageio_init_write(&pgio, hdr->inode, FLUSH_STABLE, true,
                              hdr->completion_ops);
-       set_bit(NFS_CONTEXT_RESEND_WRITES, &hdr->args.context->flags);
        return nfs_pageio_resend(&pgio, hdr);
 }
 EXPORT_SYMBOL_GPL(pnfs_write_done_resend_to_mds);