]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
6lowpan: Off by one handling ->nexthdr
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 3 Apr 2019 05:34:16 +0000 (08:34 +0300)
committerMarcel Holtmann <marcel@holtmann.org>
Tue, 23 Apr 2019 17:09:58 +0000 (19:09 +0200)
NEXTHDR_MAX is 255.  What happens here is that we take a u8 value
"hdr->nexthdr" from the network and then look it up in
lowpan_nexthdr_nhcs[].  The problem is that if hdr->nexthdr is 0xff then
we read one element beyond the end of the array so the array needs to
be one element larger.

Fixes: 92aa7c65d295 ("6lowpan: add generic nhc layer interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Acked-by: Alexander Aring <aring@mojatatu.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/6lowpan/nhc.c

index 4fa2fdda174d0139e669bd282ab4362aea41f512..9e56fb98f33cf0682991774293f77749a272478c 100644 (file)
@@ -18,7 +18,7 @@
 #include "nhc.h"
 
 static struct rb_root rb_root = RB_ROOT;
-static struct lowpan_nhc *lowpan_nexthdr_nhcs[NEXTHDR_MAX];
+static struct lowpan_nhc *lowpan_nexthdr_nhcs[NEXTHDR_MAX + 1];
 static DEFINE_SPINLOCK(lowpan_nhc_lock);
 
 static int lowpan_nhc_insert(struct lowpan_nhc *nhc)