]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/blob - queue-4.4/powerpc-boot-fix-missing-check-of-lseek-return-value.patch
Linux 4.9.181
[thirdparty/kernel/stable-queue.git] / queue-4.4 / powerpc-boot-fix-missing-check-of-lseek-return-value.patch
1 From 4dd85d768a56ed9a0a1a531d805329304a556600 Mon Sep 17 00:00:00 2001
2 From: Bo YU <tsu.yubo@gmail.com>
3 Date: Tue, 30 Oct 2018 09:21:55 -0400
4 Subject: powerpc/boot: Fix missing check of lseek() return value
5
6 [ Upstream commit 5d085ec04a000fefb5182d3b03ee46ca96d8389b ]
7
8 This is detected by Coverity scan: CID: 1440481
9
10 Signed-off-by: Bo YU <tsu.yubo@gmail.com>
11 Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
12 Signed-off-by: Sasha Levin <sashal@kernel.org>
13 ---
14 arch/powerpc/boot/addnote.c | 6 +++++-
15 1 file changed, 5 insertions(+), 1 deletion(-)
16
17 diff --git a/arch/powerpc/boot/addnote.c b/arch/powerpc/boot/addnote.c
18 index 9d9f6f334d3cc..3da3e2b1b51bc 100644
19 --- a/arch/powerpc/boot/addnote.c
20 +++ b/arch/powerpc/boot/addnote.c
21 @@ -223,7 +223,11 @@ main(int ac, char **av)
22 PUT_16(E_PHNUM, np + 2);
23
24 /* write back */
25 - lseek(fd, (long) 0, SEEK_SET);
26 + i = lseek(fd, (long) 0, SEEK_SET);
27 + if (i < 0) {
28 + perror("lseek");
29 + exit(1);
30 + }
31 i = write(fd, buf, n);
32 if (i < 0) {
33 perror("write");
34 --
35 2.20.1
36