releases/4.19.51/video-hgafb-fix-potential-null-pointer-dereference.patch

   1 From 60629e5300af6888a6a43b3bb20e830d416fcd6a Mon Sep 17 00:00:00 2001
   2 From: Kangjie Lu <kjlu@umn.edu>
   3 Date: Mon, 1 Apr 2019 17:46:58 +0200
   4 Subject: video: hgafb: fix potential NULL pointer dereference
   5
   6 [ Upstream commit ec7f6aad57ad29e4e66cc2e18e1e1599ddb02542 ]
   7
   8 When ioremap fails, hga_vram should not be dereferenced. The fix
   9 check the failure to avoid NULL pointer dereference.
  10
  11 Signed-off-by: Kangjie Lu <kjlu@umn.edu>
  12 Cc: Aditya Pakki <pakki001@umn.edu>
  13 Cc: Ferenc Bakonyi <fero@drama.obuda.kando.hu>
  14 [b.zolnierkie: minor patch summary fixup]
  15 Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
  16 Signed-off-by: Sasha Levin <sashal@kernel.org>
  17 ---
  18  drivers/video/fbdev/hgafb.c | 2 ++
  19  1 file changed, 2 insertions(+)
  20
  21 diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
  22 index 463028543173..59e1cae57948 100644
  23 --- a/drivers/video/fbdev/hgafb.c
  24 +++ b/drivers/video/fbdev/hgafb.c
  25 @@ -285,6 +285,8 @@ static int hga_card_detect(void)
  26         hga_vram_len  = 0x08000;
  27
  28         hga_vram = ioremap(0xb0000, hga_vram_len);
  29 +       if (!hga_vram)
  30 +               goto error;
  31
  32         if (request_region(0x3b0, 12, "hgafb"))
  33                 release_io_ports = 1;
  34 --
  35 2.20.1
  36