]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: rawmidi: Fix missing input substream checks in compat ioctls
authorTakashi Iwai <tiwai@suse.de>
Thu, 19 Apr 2018 16:16:15 +0000 (18:16 +0200)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:34 +0000 (21:36 -0400)
commit874ce787c160db6730d7c6314d55d7d7ea58940c
tree7789a15507eef04a7c1eaad98efacc6149d40406
parent04c18886ed5c9450fe96add7806ad7f03d163555
ALSA: rawmidi: Fix missing input substream checks in compat ioctls

[ Upstream commit 8a56ef4f3ffba9ebf4967b61ef600b0a7ba10f11 ]

Some rawmidi compat ioctls lack of the input substream checks
(although they do check only for rfile->output).  This many eventually
lead to an Oops as NULL substream is passed to the rawmidi core
functions.

Fix it by adding the proper checks before each function call.

The bug was spotted by syzkaller.

Reported-by: syzbot+f7a0348affc3b67bc617@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
sound/core/rawmidi_compat.c