]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
crypto: vmac - don't set alignmask
authorEric Biggers <ebiggers@google.com>
Thu, 19 Oct 2023 05:53:35 +0000 (22:53 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 27 Oct 2023 10:04:24 +0000 (18:04 +0800)
The vmac template is setting its alignmask to that of its underlying
'cipher'.  This doesn't actually accomplish anything useful, though, so
stop doing it.  (vmac_update() does have an alignment bug, where it
assumes u64 alignment when it shouldn't, but that bug exists both before
and after this patch.)  This is a prerequisite for removing support for
nonzero alignmasks from shash.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/vmac.c

index 4633b2dda1e0a5a4fe7f9f07e4b53468d500c44d..0a1d8efa6c1a6f42f368342f7eadef33e1b546a5 100644 (file)
@@ -649,7 +649,6 @@ static int vmac_create(struct crypto_template *tmpl, struct rtattr **tb)
 
        inst->alg.base.cra_priority = alg->cra_priority;
        inst->alg.base.cra_blocksize = alg->cra_blocksize;
-       inst->alg.base.cra_alignmask = alg->cra_alignmask;
 
        inst->alg.base.cra_ctxsize = sizeof(struct vmac_tfm_ctx);
        inst->alg.base.cra_init = vmac_init_tfm;