]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
tools: iio: replace seekdir() in iio_generic_buffer
authorPetre Rodan <petre.rodan@subdimension.ro>
Mon, 8 Jan 2024 10:32:20 +0000 (12:32 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Apr 2024 10:50:16 +0000 (12:50 +0200)
[ Upstream commit 4e6500bfa053dc133021f9c144261b77b0ba7dc8 ]

Replace seekdir() with rewinddir() in order to fix a localized glibc bug.

One of the glibc patches that stable Gentoo is using causes an improper
directory stream positioning bug on 32bit arm. That in turn ends up as a
floating point exception in iio_generic_buffer.

The attached patch provides a fix by using an equivalent function which
should not cause trouble for other distros and is easier to reason about
in general as it obviously always goes back to to the start.

https://sourceware.org/bugzilla/show_bug.cgi?id=31212

Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
Link: https://lore.kernel.org/r/20240108103224.3986-1-petre.rodan@subdimension.ro
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/iio/iio_utils.c

index d174487b2f2264398260fa4408a741be11fddef2..1ef51c7e7b04f282dce975efb14e0b5b83741c31 100644 (file)
@@ -376,7 +376,7 @@ int build_channel_array(const char *device_dir,
                goto error_close_dir;
        }
 
-       seekdir(dp, 0);
+       rewinddir(dp);
        while (ent = readdir(dp), ent) {
                if (strcmp(ent->d_name + strlen(ent->d_name) - strlen("_en"),
                           "_en") == 0) {