]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: Intel: bytcr_rt5651: Set card long_name based on quirks
authorHans de Goede <hdegoede@redhat.com>
Fri, 18 May 2018 19:35:06 +0000 (21:35 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 31 May 2018 10:28:57 +0000 (11:28 +0100)
Many X86 devices using a BYT SoC + RT5651 codec are cheap devices with
generic DMI strings, causing snd_soc_set_dmi_name() to fail to set a
long_name, making it impossible for userspace to have a correct UCM
profile which knowns which input is connected to the internal mic,
which input is connected to the hsmic (for correct jack-based switching)
and which inputs are unused.

Our quirks already specify which inputs the internal and headset mic
are connected to.

This commit sets a long_name based on the quirks so that userspace can
have UCM profiles doing the right thing based on the long_name.

Note that if we ever encounter the need for a special UCM profile for
some device we can add a quirk to set a specific long_name for the
device,

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/bytcr_rt5651.c

index 3c7d93520c5263b196b86b4ef5c39d78af5111ca..1be788e04193ac2bd4129e295dbdc5c82bd80843 100644 (file)
@@ -706,6 +706,7 @@ static struct snd_soc_card byt_rt5651_card = {
 static char byt_rt5651_codec_name[SND_ACPI_I2C_ID_LEN];
 static char byt_rt5651_codec_aif_name[12]; /*  = "rt5651-aif[1|2]" */
 static char byt_rt5651_cpu_dai_name[10]; /*  = "ssp[0|2]-port" */
+static char byt_rt5651_long_name[40]; /* = "bytcr-rt5651-*-spk-*-mic" */
 
 static bool is_valleyview(void)
 {
@@ -726,6 +727,10 @@ struct acpi_chan_package {   /* ACPICA seems to require 64 bit integers */
 
 static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
 {
+       const char * const intmic_name[] =
+               { "dmic", "in1", "in2", "in12", "in1", "in2" };
+       const char * const hsmic_name[] =
+               {  "in2", "in2", "in1",  "in3", "in3", "in3" };
        struct byt_rt5651_private *priv;
        struct snd_soc_acpi_mach *mach;
        const char *i2c_name = NULL;
@@ -870,6 +875,12 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
                }
        }
 
+       snprintf(byt_rt5651_long_name, sizeof(byt_rt5651_long_name),
+                "bytcr-rt5651-%s-intmic-%s-hsmic",
+                intmic_name[BYT_RT5651_MAP(byt_rt5651_quirk)],
+                hsmic_name[BYT_RT5651_MAP(byt_rt5651_quirk)]);
+       byt_rt5651_card.long_name = byt_rt5651_long_name;
+
        ret_val = devm_snd_soc_register_card(&pdev->dev, &byt_rt5651_card);
 
        if (ret_val) {