]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
nfp: abm: refuse RED offload with harddrop set
authorJakub Kicinski <jakub.kicinski@netronome.com>
Fri, 9 Nov 2018 03:50:39 +0000 (19:50 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Nov 2018 04:48:01 +0000 (20:48 -0800)
RED Qdisc will now inform the drivers about the state of the harddrop
flag.  Refuse to offload in case harddrop is set.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: John Hurley <john.hurley@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/abm/qdisc.c

index 979afb3ea8555c1715aa0a41d6ebda6ed1e0bd8d..bb05f9ee0401c94bbedf1e667ada55aa9c35cb1f 100644 (file)
@@ -83,6 +83,11 @@ nfp_abm_red_check_params(struct nfp_abm_link *alink,
                         opt->parent, opt->handle);
                return false;
        }
+       if (opt->set.is_harddrop) {
+               nfp_warn(cpp, "RED offload failed - harddrop is not supported (p:%08x h:%08x)\n",
+                        opt->parent, opt->handle);
+               return false;
+       }
        if (opt->set.min != opt->set.max) {
                nfp_warn(cpp, "RED offload failed - unsupported min/max parameters (p:%08x h:%08x)\n",
                         opt->parent, opt->handle);