]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
nvme-fabrics: use consistent zeroout pattern
authorChaitanya Kulkarni <kch@nvidia.com>
Wed, 12 Jan 2022 06:20:57 +0000 (22:20 -0800)
committerChristoph Hellwig <hch@lst.de>
Mon, 28 Feb 2022 11:45:04 +0000 (13:45 +0200)
Remove zeroout memeset call & zeroout local variable cmd at the time
of declaration in nvmf_ref_read32() similar to what we have done in
nvmf_reg_read64(), nvmf_reg_write32(), nvmf_connect_admin_queue(), and
nvmf_connect_io_queue().

Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/fabrics.c

index 131e78e62d00dcbdd852b96a443c75c6e39ef26b..f4aa40124720945e69c693cf8be54cd478dd386c 100644 (file)
@@ -144,11 +144,10 @@ EXPORT_SYMBOL_GPL(nvmf_get_address);
  */
 int nvmf_reg_read32(struct nvme_ctrl *ctrl, u32 off, u32 *val)
 {
-       struct nvme_command cmd;
+       struct nvme_command cmd = { };
        union nvme_result res;
        int ret;
 
-       memset(&cmd, 0, sizeof(cmd));
        cmd.prop_get.opcode = nvme_fabrics_command;
        cmd.prop_get.fctype = nvme_fabrics_type_property_get;
        cmd.prop_get.offset = cpu_to_le32(off);