]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
KVM: guest-memfd: fix unused-function warning
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 8 Dec 2023 18:46:48 +0000 (13:46 -0500)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 8 Dec 2023 18:46:48 +0000 (13:46 -0500)
With migration disabled, one function becomes unused:

virt/kvm/guest_memfd.c:262:12: error: 'kvm_gmem_migrate_folio' defined but not used [-Werror=unused-function]
  262 | static int kvm_gmem_migrate_folio(struct address_space *mapping,
      |            ^~~~~~~~~~~~~~~~~~~~~~

Remove the #ifdef around the reference so that fallback_migrate_folio()
is never used.  The gmem implementation of the hook is trivial; since
the gmem mapping is unmovable, the pages should not be migrated anyway.

Fixes: a7800aa80ea4 ("KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Suggested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
virt/kvm/guest_memfd.c

index b992723961195f87ce898222a2635d2f43fcfa7c..c2e2371720a9c74949d3801d45e6658b59b37eb9 100644 (file)
@@ -300,9 +300,7 @@ static int kvm_gmem_error_page(struct address_space *mapping, struct page *page)
 
 static const struct address_space_operations kvm_gmem_aops = {
        .dirty_folio = noop_dirty_folio,
-#ifdef CONFIG_MIGRATION
        .migrate_folio  = kvm_gmem_migrate_folio,
-#endif
        .error_remove_page = kvm_gmem_error_page,
 };