]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: mx2_emmaprp: Correct return type for mem2mem buffer helpers
authorEzequiel Garcia <ezequiel@collabora.com>
Fri, 8 Feb 2019 16:17:42 +0000 (11:17 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Apr 2019 20:29:10 +0000 (22:29 +0200)
[ Upstream commit 8d20dcefe471763f23ad538369ec65b51993ffff ]

Fix the assigned type of mem2mem buffer handling API.
Namely, these functions:

 v4l2_m2m_next_buf
 v4l2_m2m_last_buf
 v4l2_m2m_buf_remove
 v4l2_m2m_next_src_buf
 v4l2_m2m_next_dst_buf
 v4l2_m2m_last_src_buf
 v4l2_m2m_last_dst_buf
 v4l2_m2m_src_buf_remove
 v4l2_m2m_dst_buf_remove

return a struct vb2_v4l2_buffer, and not a struct vb2_buffer.

Fixing this is necessary to fix the mem2mem buffer handling API,
changing the return to the correct struct vb2_v4l2_buffer instead
of a void pointer.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/mx2_emmaprp.c

index e68d271b10afa1ec47b28a62073f3e97a78e235c..8354ad20865aea36ab4d66115ad909741db5e7a8 100644 (file)
@@ -288,7 +288,7 @@ static void emmaprp_device_run(void *priv)
 {
        struct emmaprp_ctx *ctx = priv;
        struct emmaprp_q_data *s_q_data, *d_q_data;
-       struct vb2_buffer *src_buf, *dst_buf;
+       struct vb2_v4l2_buffer *src_buf, *dst_buf;
        struct emmaprp_dev *pcdev = ctx->dev;
        unsigned int s_width, s_height;
        unsigned int d_width, d_height;
@@ -308,8 +308,8 @@ static void emmaprp_device_run(void *priv)
        d_height = d_q_data->height;
        d_size = d_width * d_height;
 
-       p_in = vb2_dma_contig_plane_dma_addr(src_buf, 0);
-       p_out = vb2_dma_contig_plane_dma_addr(dst_buf, 0);
+       p_in = vb2_dma_contig_plane_dma_addr(&src_buf->vb2_buf, 0);
+       p_out = vb2_dma_contig_plane_dma_addr(&dst_buf->vb2_buf, 0);
        if (!p_in || !p_out) {
                v4l2_err(&pcdev->v4l2_dev,
                         "Acquiring kernel pointers to buffers failed\n");