]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rtc: imx-sc: Align imx sc msg structs to 4
authorLeonard Crestez <leonard.crestez@nxp.com>
Thu, 20 Feb 2020 16:29:38 +0000 (18:29 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 29 Mar 2020 20:08:35 +0000 (22:08 +0200)
The imx SC api strongly assumes that messages are composed out of
4-bytes words but some of our message structs have odd sizeofs.

This produces many oopses with CONFIG_KASAN=y.

Fix by marking with __aligned(4).

Fixes: a3094fc1a15e ("rtc: imx-sc: add rtc alarm support")
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Link: https://lore.kernel.org/r/13404bac8360852d86c61fad5ae5f0c91ffc4cb6.1582216144.git.leonard.crestez@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-imx-sc.c

index cf2c12107f2b8266afdf08c207691cb1f989ee9a..a5f59e6f862e017d3ed81b962941f31f5f11f733 100644 (file)
@@ -37,7 +37,7 @@ struct imx_sc_msg_timer_rtc_set_alarm {
        u8 hour;
        u8 min;
        u8 sec;
-} __packed;
+} __packed __aligned(4);
 
 static int imx_sc_rtc_read_time(struct device *dev, struct rtc_time *tm)
 {