]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
Drivers: hv: balloon: add a fall through comment to hv_memory_notifier()
authorVitaly Kuznetsov <vkuznets@redhat.com>
Sat, 28 Jan 2017 19:37:16 +0000 (12:37 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 31 Jan 2017 10:05:58 +0000 (11:05 +0100)
Coverity scan gives a warning when there is fall through in a switch
without a comment. This fall through is intentional as ol_waitevent needs
to be completed to unblock hv_mem_hot_add() allowing it to process next
requests regardless of the result of if we were able to online this block.

Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hv/hv_balloon.c

index 14c3dc4bd23c0b81c1a6cd2df84179af6963ab49..5fd03e59cee563dca301f7ce5c294de298510eab 100644 (file)
@@ -587,6 +587,7 @@ static int hv_memory_notifier(struct notifier_block *nb, unsigned long val,
                spin_lock_irqsave(&dm_device.ha_lock, flags);
                dm_device.num_pages_onlined += mem->nr_pages;
                spin_unlock_irqrestore(&dm_device.ha_lock, flags);
+               /* Fall through */
        case MEM_CANCEL_ONLINE:
                if (dm_device.ha_waiting) {
                        dm_device.ha_waiting = false;