]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: phy: ab8500: silence some uninitialized variable warnings
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 18 Oct 2018 08:04:00 +0000 (11:04 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Oct 2018 17:44:39 +0000 (19:44 +0200)
Smatch complains that "reg" can be uninitialized if the
abx500_get_register_interruptible() call fails.  It's an interruptable
function, so we should check if the user presses CTRL-C.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/phy/phy-ab8500-usb.c

index 66143ab8c043cc9cf22d1c0f97e3cf841942315b..aaf363f19714671aaf75482ead3b2ba5ad6b1174 100644 (file)
@@ -505,15 +505,19 @@ static int abx500_usb_link_status_update(struct ab8500_usb *ab)
        if (is_ab8500(ab->ab8500)) {
                enum ab8500_usb_link_status lsts;
 
-               abx500_get_register_interruptible(ab->dev,
+               ret = abx500_get_register_interruptible(ab->dev,
                                AB8500_USB, AB8500_USB_LINE_STAT_REG, &reg);
+               if (ret < 0)
+                       return ret;
                lsts = (reg >> 3) & 0x0F;
                ret = ab8500_usb_link_status_update(ab, lsts);
        } else if (is_ab8505(ab->ab8500)) {
                enum ab8505_usb_link_status lsts;
 
-               abx500_get_register_interruptible(ab->dev,
+               ret = abx500_get_register_interruptible(ab->dev,
                                AB8500_USB, AB8505_USB_LINE_STAT_REG, &reg);
+               if (ret < 0)
+                       return ret;
                lsts = (reg >> 3) & 0x1F;
                ret = ab8505_usb_link_status_update(ab, lsts);
        }