]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
Revert "drm/amd/display: Don't skip link training for empty dongle"
authorHarry Wentland <harry.wentland@amd.com>
Tue, 21 Jan 2020 21:29:54 +0000 (16:29 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 27 Jan 2020 21:46:45 +0000 (16:46 -0500)
This reverts commit 80adaebd2d411b7d6872a097634848a71eb13d20.

[WHY]
This change was working around a regression that occured in this:
commit 0301ccbaf67d ("drm/amd/display: DP Compliance 400.1.1 failure")

With the fix to run verify_link_cap when the SINK_COUNT of
dongles becomes non-zero this change is no longer needed.

Cc: Louis Li <Ching-shih.Li@amd.com>
Cc: Wenjing Liu <Wenjing.Liu@amd.com>
Cc: Hersen Wu <hersenxs.wu@amd.com>
Cc: Eric Yang <Eric.Yang2@amd.com>
Reviewed-by: Wenjing Liu <Wenjing.Liu@amd.com>
Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_link.c

index cc2e050035954413ff18cd0c1b78f0fee71602d0..a09119c10d7c9399724e45f741f985befb6b3ff9 100644 (file)
@@ -851,18 +851,12 @@ static bool dc_link_detect_helper(struct dc_link *link,
                                if (memcmp(&link->dpcd_caps, &prev_dpcd_caps, sizeof(struct dpcd_caps)))
                                        same_dpcd = false;
                        }
-                       /* Active dongle plug in without display or downstream unplug*/
+                       /* Active dongle downstream unplug*/
                        if (link->type == dc_connection_active_dongle &&
                                link->dpcd_caps.sink_count.bits.SINK_COUNT == 0) {
-                               if (prev_sink != NULL) {
+                               if (prev_sink != NULL)
                                        /* Downstream unplug */
                                        dc_sink_release(prev_sink);
-                               } else {
-                                       /* Empty dongle plug in */
-                                       dp_verify_link_cap_with_retries(link,
-                                                       &link->reported_link_cap,
-                                                       LINK_TRAINING_MAX_VERIFY_RETRY);
-                               }
                                return true;
                        }