]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
IB/hfi1: Fix a build warning for TID RDMA READ
authorKaike Wan <kaike.wan@intel.com>
Fri, 15 Feb 2019 21:45:30 +0000 (13:45 -0800)
committerJason Gunthorpe <jgg@mellanox.com>
Fri, 15 Feb 2019 22:55:50 +0000 (15:55 -0700)
The following build warning was produced for the TID RDMA READ
patch ("IB/hfi1: Enable TID RDMA READ protocol"):

drivers/infiniband/hw/hfi1/qp.c: In function 'hfi1_setup_wqe':
drivers/infiniband/hw/hfi1/qp.c:328:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   hfi1_setup_tid_rdma_wqe(qp, wqe);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/hw/hfi1/qp.c:329:2: note: here
  case IB_QPT_UC:
  ^~~~

This patch will fix the issue by adding the "fall through" comment.

Fixes: f1ab4efa6d32 ("IB/hfi1: Enable TID RDMA READ protocol")
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Kaike Wan <kaike.wan@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hfi1/qp.c

index d8f7add935dffc51e208d31b6e9a4de2d5f375e7..9b643c2409cf8bee5c28084b104c2839bc5768aa 100644 (file)
@@ -326,6 +326,7 @@ int hfi1_setup_wqe(struct rvt_qp *qp, struct rvt_swqe *wqe, bool *call_send)
        switch (qp->ibqp.qp_type) {
        case IB_QPT_RC:
                hfi1_setup_tid_rdma_wqe(qp, wqe);
+               /* fall through */
        case IB_QPT_UC:
                if (wqe->length > 0x80000000U)
                        return -EINVAL;