]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
KVM: x86/mmu: fix comment about mmu_unsync_pages_lock
authorPaolo Bonzini <pbonzini@redhat.com>
Sat, 25 Nov 2023 08:34:00 +0000 (03:34 -0500)
committerSean Christopherson <seanjc@google.com>
Fri, 1 Dec 2023 15:52:09 +0000 (07:52 -0800)
Fix the comment about what can and cannot happen when mmu_unsync_pages_lock
is not help.  The comment correctly mentions "clearing sp->unsync", but then
it talks about unsync going from 0 to 1.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Link: https://lore.kernel.org/r/20231125083400.1399197-5-pbonzini@redhat.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/mmu/mmu.c

index ace9f7c13132281e92796a197af31738a74fed29..3fec3f6cdd53a48e360eaa1991e3515ed60c0037 100644 (file)
@@ -2850,9 +2850,9 @@ int mmu_try_to_unsync_pages(struct kvm *kvm, const struct kvm_memory_slot *slot,
                        /*
                         * Recheck after taking the spinlock, a different vCPU
                         * may have since marked the page unsync.  A false
-                        * positive on the unprotected check above is not
+                        * negative on the unprotected check above is not
                         * possible as clearing sp->unsync _must_ hold mmu_lock
-                        * for write, i.e. unsync cannot transition from 0->1
+                        * for write, i.e. unsync cannot transition from 1->0
                         * while this CPU holds mmu_lock for read (or write).
                         */
                        if (READ_ONCE(sp->unsync))