]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests/net: correct the return value for run_netsocktests
authorPo-Hsu Lin <po-hsu.lin@canonical.com>
Thu, 18 Apr 2019 11:57:25 +0000 (19:57 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 May 2019 07:17:23 +0000 (09:17 +0200)
[ Upstream commit 30c04d796b693e22405c38e9b78e9a364e4c77e6 ]

The run_netsocktests will be marked as passed regardless the actual test
result from the ./socket:

    selftests: net: run_netsocktests
    ========================================
    --------------------
    running socket test
    --------------------
    [FAIL]
    ok 1..6 selftests: net: run_netsocktests [PASS]

This is because the test script itself has been successfully executed.
Fix this by exit 1 when the test failed.

Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/net/run_netsocktests

index c09a682df56ae9fb3cc91214ae9d79da19714633..19486dab2379e50e00de5902bfa9d5480e5420c1 100644 (file)
@@ -6,7 +6,7 @@ echo "--------------------"
 ./socket
 if [ $? -ne 0 ]; then
        echo "[FAIL]"
+       exit 1
 else
        echo "[PASS]"
 fi
-