x86/vdso: Prevent segfaults due to hoisted vclock reads

GCC 5.5.0 sometimes cleverly hoists reads of the pvclock and/or hvclock
pages before the vclock mode checks.  This creates a path through
vclock_gettime() in which no vclock is enabled at all (due to disabled
TSC on old CPUs, for example) but the pvclock or hvclock page
nevertheless read.  This will segfault on bare metal.

This fixes commit 459e3a21535a ("gcc-9: properly declare the
{pv,hv}clock_page storage") in the sense that, before that commit, GCC
didn't seem to generate the offending code.  There was nothing wrong
with that commit per se, and -stable maintainers should backport this to
all supported kernels regardless of whether the offending commit was
present, since the same crash could just as easily be triggered by the
phase of the moon.

On GCC 9.1.1, this doesn't seem to affect the generated code at all, so
I'm not too concerned about performance regressions from this fix.

Cc: stable@vger.kernel.org
Cc: x86@kernel.org
Cc: Borislav Petkov <bp@alien8.de>
Reported-by: Duncan Roe <duncan_roe@optusnet.com.au>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/arch/x86/entry/vdso/vclock_gettime.c b/arch/x86/entry/vdso/vclock_gettime.c
index 0f82a70c7682c4973c7ffd1166755fbf01380f44..4aed41f638bb09f8ac575d683583cef6e8c564c9 100644 (file)
--- a/arch/x86/entry/vdso/vclock_gettime.c
+++ b/arch/x86/entry/vdso/vclock_gettime.c
@@ -128,13 +128,24 @@ notrace static inline u64 vgetcyc(int mode)
 {
        if (mode == VCLOCK_TSC)
                return (u64)rdtsc_ordered();
 {
        if (mode == VCLOCK_TSC)
                return (u64)rdtsc_ordered();

+
+       /*
+        * For any memory-mapped vclock type, we need to make sure that gcc
+        * doesn't cleverly hoist a load before the mode check.  Otherwise we
+        * might end up touching the memory-mapped page even if the vclock in
+        * question isn't enabled, which will segfault.  Hence the barriers.
+        */

 #ifdef CONFIG_PARAVIRT_CLOCK
 #ifdef CONFIG_PARAVIRT_CLOCK

-       else if (mode == VCLOCK_PVCLOCK)
+       if (mode == VCLOCK_PVCLOCK) {
+               barrier();

                return vread_pvclock();
                return vread_pvclock();

+       }

 #endif
 #ifdef CONFIG_HYPERV_TSCPAGE
 #endif
 #ifdef CONFIG_HYPERV_TSCPAGE

-       else if (mode == VCLOCK_HVCLOCK)
+       if (mode == VCLOCK_HVCLOCK) {
+               barrier();

                return vread_hvclock();
                return vread_hvclock();

+       }

 #endif
        return U64_MAX;
 }
 #endif
        return U64_MAX;
 }