]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bnx2x: Prevent load reordering in tx completion processing
authorBrian King <brking@linux.vnet.ibm.com>
Mon, 15 Jul 2019 21:41:50 +0000 (16:41 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sun, 21 Jul 2019 19:29:25 +0000 (12:29 -0700)
commitea811b795df24644a8eb760b493c43fba4450677
treef5d8400080437a0ba12ca8f66d7e031b17c99ad1
parent0cea0e1148fe134a4a3aaf0b1496f09241fb943a
bnx2x: Prevent load reordering in tx completion processing

This patch fixes an issue seen on Power systems with bnx2x which results
in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb
pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons
load in bnx2x_tx_int. Adding a read memory barrier resolves the issue.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c