libkmod-module: fix return code in error path

ENOSYS is the wrong errno to return when we don't find a module in
kmod_module_insert_module(). Why is it there in the first place?  This
goes back to kmod v1 when we couldn't load modules by names, but we
should give a path instead.

708624a ("ELF: initial support for modinfo and strip of modversions and
vermagic.") changed that so we do a lazy-search by the module path in
this function. Later  f304afe ("Change error message to reflect
reality") fixed the log message but the return coded remained the same.

diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c
index 366308f5d65cb1dcaa5a2b253363a9cea25fa227..50b2ff9f5eefb678ba8db852a1cb45ff2f02ed1f 100644 (file)
--- a/libkmod/libkmod-module.c
+++ b/libkmod/libkmod-module.c
@@ -830,7 +830,7 @@ KMOD_EXPORT int kmod_module_insert_module(struct kmod_module *mod,
        path = kmod_module_get_path(mod);
        if (path == NULL) {
                ERR(mod->ctx, "could not find module by name='%s'\n", mod->name);
-               return -ENOSYS;
+               return -ENOENT;
        }
 
        mod->file = kmod_file_open(mod->ctx, path);