RAR5 reader: fix unsafe sign check of a bitwise operation.

This has no but code correctness effect as cdeque_init() is static
and max_capacity_power_of_2 in our code is always 8192.

Found by LGTM.com code analysis

diff --git a/libarchive/archive_read_support_format_rar5.c b/libarchive/archive_read_support_format_rar5.c
index 26374582e4d60f37ce792e45442b73ea65628b1b..1c1cd7961abd0521be870f472e8c83c22e4256f7 100644 (file)
--- a/libarchive/archive_read_support_format_rar5.c
+++ b/libarchive/archive_read_support_format_rar5.c
@@ -384,7 +384,7 @@ static int cdeque_init(struct cdeque* d, int max_capacity_power_of_2) {
        d->cap_mask = max_capacity_power_of_2 - 1;
        d->arr = NULL;
 
-       if((max_capacity_power_of_2 & d->cap_mask) > 0)
+       if((max_capacity_power_of_2 & d->cap_mask) != 0)
                return CDE_PARAM;
 
        cdeque_clear(d);